Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support accepting null on mount #652

Merged
merged 1 commit into from Jan 22, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Jan 22, 2020

Type: feature

The following has been addressed in the PR:

Description:

Support a null domNode on mount, if null is received then it will default to the document body but output a warning when in dev mode (as usually null will be received when a dom node using getElementById could not be found).

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 19fc84e:

Sandbox Source
practical-ives-4e114 Configuration

@agubler agubler merged commit 2c8185d into dojo:master Jan 22, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants