Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable diffProperty to influence widget properties #653

Merged
merged 7 commits into from Jan 24, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Jan 22, 2020

Type: feature

The following has been addressed in the PR:

Description:

One use case for diffProperty is to be able to influence the property value when executing the diff property callback. For example in the theme middleware, it adds an optional theme property to a widget that will be used over the currently loaded theme in the injector. However if no property is explicitly passed to the widget, the theme property should be set to the injected theme and available in the downstream widget.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2420ccf:

Sandbox Source
romantic-snowflake-0irjf Configuration

@agubler agubler merged commit e538f9e into dojo:master Jan 24, 2020
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants