Specify a property that is used as key for a widget#661
Merged
agubler merged 2 commits intodojo:masterfrom Jan 30, 2020
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 79c7e6a:
|
agubler
force-pushed
the
automatic-key
branch
from
0659f41 to
97f8c01
Compare
agubler
force-pushed
the
automatic-key
branch
from
97f8c01 to
dd4c9ac
Compare
matt-gadd
approved these changes
Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
A chained
.keyfunction that enables middleware and widgets to specify property names that are considered "primary keys" to be used as thekeyfor the widget itself. This means that the author a widget can control the when it will be recreated by the Dojo rendering engine based on changes to properties.Resolves #658