Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to the root bundle when no locales are configured #677

Merged
merged 9 commits into from
Feb 20, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Feb 19, 2020

Type: bug

The following has been addressed in the PR:

Description:

  • Use a basic message loader when i18n has not been configured for the application.
  • Load the fallback cldr for unknown locales that are passed to localizeBundle but not set through changing the local via the i18n middleware or mixin.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #677 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
- Coverage   97.80%   97.78%   -0.03%     
==========================================
  Files         117      117              
  Lines        6570     6585      +15     
  Branches     1494     1500       +6     
==========================================
+ Hits         6426     6439      +13     
- Misses        144      146       +2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 824a7b3...ec95eeb. Read the comment docs.

@agubler agubler merged commit 2b40317 into dojo:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants