Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmount Application #680

Merged
merged 2 commits into from Feb 20, 2020
Merged

Unmount Application #680

merged 2 commits into from Feb 20, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Feb 20, 2020

Type: feature

The following has been addressed in the PR:

Description:

Adds unmount to the renderer to fully detached and unmount an entire application.

Resolves #676

@agubler agubler merged commit 38e9037 into dojo:master Feb 20, 2020
2 of 4 checks passed
@joeldenning
Copy link

joeldenning commented Feb 23, 2020

Amazing - thanks. Looking forward to this being released. One single-spa user is on dojo@6 so I think they would appreciate this being backported to dojo 6 if possible too.

I appreciate the prompt response and your work on this.

agubler added a commit to agubler/framework that referenced this issue Mar 5, 2020
* Add unmount

* remove console.log
@agubler agubler mentioned this pull request Mar 6, 2020
3 tasks
agubler added a commit that referenced this issue Mar 9, 2020
* Add unmount

* remove console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants