Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync nls bundles for supported locales #686

merged 1 commit into from Mar 18, 2020


Copy link

@agubler agubler commented Mar 13, 2020

Type: bug

The following has been addressed in the PR:


Fix sync nls bundles for registered supported locales.

Copy link

codesandbox-ci bot commented Mar 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7e93092:

Sandbox Source
condescending-merkle-qm3m8 Configuration

@agubler agubler force-pushed the bug-non-lazy-nls-bundles-not-loading branch from 6454a5f to 7e93092 Compare Mar 18, 2020
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #686 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #686   +/-   ##
  Coverage   97.77%   97.77%           
  Files         117      117           
  Lines        6615     6615           
  Branches     1502     1502           
  Hits         6468     6468           
  Misses        147      147           
Impacted Files Coverage Δ
src/i18n/i18n.ts 98.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d03fae...7e93092. Read the comment docs.

@agubler agubler merged commit 54133de into dojo:master Mar 18, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants