Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the current locale if no locale is set via properties or injector #694

Merged
merged 1 commit into from Mar 19, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Mar 18, 2020

Type: bug

The following has been addressed in the PR:

Description:

The i18n middleware should set the locale property to be the computed locale from the default locale that has been set.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 37df8cf:

Sandbox Source
goofy-colden-bm2p5 Configuration

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #694 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   97.75%   97.80%   +0.05%     
==========================================
  Files         119      119              
  Lines        6892     6891       -1     
  Branches     1556     1555       -1     
==========================================
+ Hits         6737     6740       +3     
+ Misses        155      151       -4     
Impacted Files Coverage Δ
src/i18n/i18n.ts 98.90% <ø> (-0.01%) ⬇️
src/core/middleware/i18n.ts 91.37% <100.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc4da02...4a2b872. Read the comment docs.

@agubler agubler force-pushed the set-locale-to-current-locale branch from 4a2b872 to 37df8cf Compare March 19, 2020 13:19
@agubler agubler merged commit 873d2a0 into dojo:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants