Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting variant through the theme injector #711

Merged
merged 2 commits into from Apr 1, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Apr 1, 2020

Type: bug

The following has been addressed in the PR:

Description:

Support setting variants via the theme injector.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 036d83d:

Sandbox Source
competent-dawn-8hgf6 Configuration

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #711 into master will decrease coverage by 0.00%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage   97.76%   97.75%   -0.01%     
==========================================
  Files         119      120       +1     
  Lines        6929     6949      +20     
  Branches     1573     1577       +4     
==========================================
+ Hits         6774     6793      +19     
- Misses        155      156       +1     
Impacted Files Coverage Δ
src/core/mixins/Themed.ts 97.11% <80.00%> (+0.02%) ⬆️
src/core/ThemeInjector.ts 94.73% <94.73%> (ø)
src/core/middleware/theme.ts 95.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3064b7c...036d83d. Read the comment docs.

tomdye
tomdye approved these changes Apr 1, 2020
Copy link
Member

@tomdye tomdye left a comment

Tested with latest widgets and parade, looks good to me

@agubler agubler merged commit 5321b05 into dojo:master Apr 1, 2020
9 of 11 checks passed
agubler added a commit to agubler/framework that referenced this pull request Apr 3, 2020
* Support variants when using the theme context from registering a theme

* Support custom variants via set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants