Support setting variant through the theme injector - #711
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 036d83d:
|
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
- Coverage 97.76% 97.75% -0.01%
==========================================
Files 119 120 +1
Lines 6929 6949 +20
Branches 1573 1577 +4
==========================================
+ Hits 6774 6793 +19
- Misses 155 156 +1
Continue to review full report at Codecov.
|
tomdye
approved these changes
Apr 1, 2020
tomdye
left a comment
tomdye
left a comment
Member
There was a problem hiding this comment.
Tested with latest widgets and parade, looks good to me
agubler
added a commit
to agubler/framework
that referenced
this pull request
Apr 3, 2020
* Support variants when using the theme context from registering a theme * Support custom variants via set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Support setting variants via the theme injector.