Bug: Widgets can render twice during a scheduled render #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
added
needs back-port
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4b51411:
|
agubler
force-pushed
the
do-not-mark-dirty-during-render
branch
from
50f7039 to
4b51411
Compare
Codecov Report
@@ Coverage Diff @@
## master #712 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 120 120
Lines 6949 6949
Branches 1577 1577
=======================================
Hits 6793 6793
Misses 156 156
Continue to review full report at Codecov.
|
jellison
approved these changes
Apr 1, 2020
matt-gadd
approved these changes
Apr 2, 2020
agubler
added a commit
to agubler/framework
that referenced
this pull request
Apr 3, 2020
* failing unit test for rendering twice during a scheduled render * mark dirty false after render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Widgets can end up rendering twice during a single scheduled render which can cause issues with the rendered dom and cause unnecessary processing. This happens when the widget and a parent of a widget is invalidated and ends up rendering due to a property changes or being marked as dirty - then during the render something marks the widget dirty again which means it's rendered again.
The widget should be marked as not dirty after the render and not before.
codesandbox: https://codesandbox.io/s/dreamy-swartz-dco38