Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use theme injector for custom elements #720

Merged
merged 1 commit into from Apr 7, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Apr 7, 2020

Type: bug

The following has been addressed in the PR:

Description:

To support themes with variants in custom elements it needs to use the theme injector. At the moment support is restricted to the default variant.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3afe05b:

Sandbox Source
great-chaplygin-fu5e0 Configuration

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #720 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files         120      120           
  Lines        6988     6989    +1     
  Branches     1588     1588           
=======================================
+ Hits         6832     6833    +1     
  Misses        156      156           
Impacted Files Coverage Δ
src/core/ThemeInjector.ts 95.00% <100.00%> (+0.26%) ⬆️
src/core/registerCustomElement.ts 97.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3947923...3afe05b. Read the comment docs.

@agubler agubler force-pushed the use-theme-injector-for-ce branch from f68e25e to 3afe05b Compare Apr 7, 2020
@agubler agubler merged commit baf65db into dojo:master Apr 7, 2020
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants