Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom element slot updates #721

Merged
merged 7 commits into from Apr 7, 2020
Merged

Conversation

rorticus
Copy link
Contributor

@rorticus rorticus commented Apr 7, 2020

Type: bug

The following has been addressed in the PR:

Description:

Fixing bugs with custom element slots, and cleaning up code.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fec6c55:

Sandbox Source
nifty-surf-1l9nl Configuration

@rorticus rorticus changed the title Ce slot updates custom element slot updates Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #721 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #721   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files         120      120           
  Lines        6974     6988   +14     
  Branches     1585     1588    +3     
=======================================
+ Hits         6818     6832   +14     
  Misses        156      156           
Impacted Files Coverage Δ
src/core/registerCustomElement.ts 97.74% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719e088...fec6c55. Read the comment docs.

agubler
agubler approved these changes Apr 7, 2020
@rorticus rorticus merged commit 3947923 into dojo:master Apr 7, 2020
11 checks passed
@rorticus rorticus deleted the ce-slot-updates branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants