Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow i18n to be reset to an empty state #724

Merged
merged 2 commits into from Apr 9, 2020
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Apr 9, 2020

Type: bug

The following has been addressed in the PR:

Description:

When i18n is set to an empty state it should clear the injected values and reset the locale back to the computed locale. Currently the injector is being cleared but the actual locale is not being reset to the initial locale.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b59167e:

Sandbox Source
busy-tdd-msqbw Configuration

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #724 into master will increase coverage by 0.00%.
The diff coverage is 57.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         121      121           
  Lines        7050     7051    +1     
  Branches     1603     1604    +1     
=======================================
+ Hits         6894     6895    +1     
  Misses        156      156           
Impacted Files Coverage Δ
src/i18n/i18n.ts 98.90% <ø> (ø)
src/core/middleware/i18n.ts 91.22% <57.14%> (-0.16%) ⬇️
src/stores/process.ts 99.33% <0.00%> (ø)
src/core/middleware/data.ts 100.00% <0.00%> (ø)
src/testing/mocks/middleware/focus.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cead544...b59167e. Read the comment docs.

@agubler agubler merged commit 05c3783 into dojo:master Apr 9, 2020
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants