Allow i18n to be reset to an empty state #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b59167e:
|
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 121 121
Lines 7050 7051 +1
Branches 1603 1604 +1
=======================================
+ Hits 6894 6895 +1
Misses 156 156
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
When i18n is set to an empty state it should clear the injected values and reset the locale back to the computed locale. Currently the injector is being cleared but the actual locale is not being reset to the initial locale.