Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the browser deal with url changes when in BTR and using the CLI serve #729

Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Apr 16, 2020

Type: feature

The following has been addressed in the PR:

Description:

In order to support on-demand BTR when not in static mode the link should let the browser deal with the routing navigation.

Related to dojo/cli-build-app#367

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cae97da:

Sandbox Source
nervous-wind-7vqjr Configuration

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #729 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #729   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files         125      125           
  Lines        7485     7487    +2     
  Branches     1718     1719    +1     
=======================================
+ Hits         7315     7317    +2     
  Misses        170      170           
Impacted Files Coverage Δ
src/routing/Link.ts 95.23% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edbf841...cae97da. Read the comment docs.

@agubler agubler merged commit 958ded0 into dojo:master Apr 16, 2020
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants