Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numbers in vdom #781

merged 1 commit into from
Jun 29, 2020

Allow numbers in vdom #781

merged 1 commit into from
Jun 29, 2020


Copy link

@maier49 maier49 commented May 22, 2020

Type: feature

The following has been addressed in the PR:

This would accept numbers as DNodes and render them. This seems straightforward so I'm not sure if there's any other reason we wouldn't want to allow this. I don't think we'd want to render booleans this way given the utility of the common boolean && node pattern.
Resolves #761

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 43bc3fd:

Sandbox Source
pensive-margulis-z2bwy Configuration
adoring-leavitt-su0o3 Issue #761

Copy link

@rorticus rorticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #781 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #781      +/-   ##
+ Coverage   97.48%   97.51%   +0.03%     
  Files         126      127       +1     
  Lines        7624     7725     +101     
  Branches     1759     1773      +14     
+ Hits         7432     7533     +101     
  Misses        192      192              
Impacted Files Coverage Δ
src/core/vdom.ts 97.98% <100.00%> (+<0.01%) ⬆️
src/testing/assertRender.ts 95.65% <100.00%> (ø)
src/testing/harness/support/assertRender.ts 98.23% <100.00%> (ø)
src/routing/Router.ts 100.00% <0.00%> (ø)
src/core/middleware/drag.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57efcae...43bc3fd. Read the comment docs.

@maier49 maier49 merged commit e548f88 into dojo:master Jun 29, 2020
@maier49 maier49 deleted the numbers-booleans branch June 29, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Better ergonomics around numbers/booleans
3 participants