Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intrinsic element types #796

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented May 27, 2020

**Type:**feature

The following has been addressed in the PR:

Description:
Expands on the work in #795 to add intrinsic element types for a bunch of other elements.
Resolves #735

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b72cfa8:

Sandbox Source
cold-butterfly-lts37 Configuration

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #796 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
+ Coverage   97.48%   97.52%   +0.04%     
==========================================
  Files         126      126              
  Lines        7624     7927     +303     
  Branches     1759     1824      +65     
==========================================
+ Hits         7432     7731     +299     
- Misses        192      196       +4     
Impacted Files Coverage Δ
src/core/vdom.ts 97.97% <ø> (ø)
src/testing/renderer.ts 97.58% <0.00%> (-0.01%) ⬇️
src/routing/Router.ts 100.00% <0.00%> (ø)
src/testing/harness/harness.ts 91.83% <0.00%> (ø)
src/core/resource.ts
src/core/middleware/data.ts
src/core/middleware/resources.ts 98.56% <0.00%> (ø)
src/core/middleware/drag.ts 100.00% <0.00%> (ø)
src/testing/assertRender.ts 95.86% <0.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57efcae...b72cfa8. Read the comment docs.

@maier49 maier49 merged commit b92891a into dojo:master Jun 25, 2020
@maier49 maier49 deleted the intrinsic-element-types branch June 25, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error messaging for wrong property types
2 participants