Re-use DOM nodes when moving widgets and nodes in a list#799
Merged
agubler merged 4 commits intodojo:masterfrom Aug 4, 2020
Merged
Re-use DOM nodes when moving widgets and nodes in a list#799agubler merged 4 commits intodojo:masterfrom
agubler merged 4 commits intodojo:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ea2ed7b:
|
agubler
force-pushed
the
smarter-dom-reuse
branch
from
705108f to
641725d
Compare
agubler
changed the title
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
==========================================
+ Coverage 97.57% 97.59% +0.01%
==========================================
Files 127 127
Lines 7970 8012 +42
Branches 1839 1851 +12
==========================================
+ Hits 7777 7819 +42
Misses 193 193
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Currently the rendering system, detached and re-creates DOM nodes when moving nodes in a list. This change adds the capability to re-parent (aka move) the DOM nodes instead of tearing them down and recreating them.
This is related to an issue reported on the js-framework-benchmark project krausest/js-framework-benchmark#694