Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu to button type type #814

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Jul 15, 2020

Type: bug

The following has been addressed in the PR:

Description:
Allows "menu" for button type attribute

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d91acea:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #814 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #814   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files         127      127           
  Lines        7947     7959   +12     
  Branches     1828     1835    +7     
=======================================
+ Hits         7751     7763   +12     
  Misses        196      196           
Impacted Files Coverage Δ
src/core/vdom.ts 97.99% <100.00%> (+<0.01%) ⬆️
src/testing/assertRender.ts 95.86% <100.00%> (ø)
src/testing/harness/support/assertRender.ts 98.23% <100.00%> (ø)
src/testing/renderer.ts 97.64% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9faf2c...2ffe01e. Read the comment docs.

@maier49 maier49 merged commit 48c87ed into dojo:master Jul 21, 2020
@maier49 maier49 deleted the add-menu-type-to-button branch July 21, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants