Custom element updates for dynamic loading#825
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 85c1e37:
|
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
==========================================
- Coverage 97.64% 94.83% -2.82%
==========================================
Files 127 127
Lines 8034 8034
Branches 1861 1862 +1
==========================================
- Hits 7845 7619 -226
- Misses 189 415 +226
Continue to review full report at Codecov.
|
rorticus
left a comment
There was a problem hiding this comment.
Do you think its worth making the promise bit optional for backwards compatibility reasons? So we basically look and see if a promise was returned and if so, await it, otherwise just carry on?
|
@rorticus Awaiting a synchronous value is fine though right? And the |
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Framework changes as described in #770