Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom element updates for dynamic loading #825

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Aug 13, 2020

Type: feature

The following has been addressed in the PR:

Description:
Framework changes as described in #770

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85c1e37:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #825 into master will decrease coverage by 2.81%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
- Coverage   97.64%   94.83%   -2.82%     
==========================================
  Files         127      127              
  Lines        8034     8034              
  Branches     1861     1862       +1     
==========================================
- Hits         7845     7619     -226     
- Misses        189      415     +226     
Impacted Files Coverage Δ
src/core/registerCustomElement.ts 6.53% <50.00%> (-91.03%) ⬇️
src/core/mixins/Themed.ts 99.00% <0.00%> (-1.00%) ⬇️
src/core/vdom.ts 97.91% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7cf6b9...85c1e37. Read the comment docs.

Copy link
Contributor

@rorticus rorticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think its worth making the promise bit optional for backwards compatibility reasons? So we basically look and see if a promise was returned and if so, await it, otherwise just carry on?

@maier49
Copy link
Contributor Author

maier49 commented Aug 24, 2020

@rorticus Awaiting a synchronous value is fine though right? And the _readyCallback is already called asynchronously so I'm not sure where the problem would be there. The issues with backwards compatibility would be always expecting a factory function instead of the WidgetConstructor itself like we used to. But I'm not sure there's a way around that (and it should be fixed by just rebuilding unless it was being used manually).

@maier49 maier49 merged commit f2c957a into dojo:master Sep 10, 2020
@maier49 maier49 deleted the ce-loader branch September 10, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants