-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom element updates for dynamic loading #825
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 85c1e37:
|
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
==========================================
- Coverage 97.64% 94.83% -2.82%
==========================================
Files 127 127
Lines 8034 8034
Branches 1861 1862 +1
==========================================
- Hits 7845 7619 -226
- Misses 189 415 +226
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think its worth making the promise bit optional for backwards compatibility reasons? So we basically look and see if a promise was returned and if so, await it, otherwise just carry on?
@rorticus Awaiting a synchronous value is fine though right? And the |
Type: feature
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
Framework changes as described in #770