Fix redirect on an application load#868
Merged
agubler merged 4 commits intodojo:masterfrom Dec 2, 2020
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8a93efa:
|
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 127 127
Lines 8104 8116 +12
Branches 1892 1893 +1
=======================================
+ Hits 7677 7689 +12
Misses 427 427
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
For redirecting on application load the router needs to make sure the history manager instance is set before processing the initial path in case it requires a redirect (which needs the history instance).
This is breaking as it requires introducing a "start" function to the history managers.