Update insertSiblings type definition#872
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 44e0ce9:
|
Codecov Report
@@ Coverage Diff @@
## master #872 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 127 127
Lines 8130 8130
Branches 1894 1894
=======================================
Hits 7701 7701
Misses 429 429
Continue to review full report at Codecov.
|
samends
changed the title
samends
changed the title
Member
|
@samends I think we can add a test that uses this API with a function based widget - without your changes it should fail with compilation errors and after should work? |
Author
|
Make sense, I'll add that in |
samends
force-pushed
the
issue-870-insert-siblings
branch
from
41cb59b to
44e0ce9
Compare
agubler
approved these changes
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Resolves #870
Updates type definitions for
insertSiblingsfunction