Skip to content

Pass inserted flag correctly to deferred props in test renderers #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

agubler
Copy link
Member

@agubler agubler commented Feb 19, 2021

Type: bug

The following has been addressed in the PR:

Description:

For deferred properties the renderers resolve to the "final", i.e. run the deferred properties twice but it doesn't pass the inserted flag correctly.

This passes the inserted flag as true for the second process.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1759ced:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #881 (3571dcd) into master (69a6a61) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #881   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files         127      127           
  Lines        8010     8010           
  Branches     1872     1874    +2     
=======================================
  Hits         7566     7566           
  Misses        444      444           
Impacted Files Coverage Δ
src/testing/decorate.ts 98.01% <100.00%> (ø)
src/testing/harness/harness.ts 93.87% <100.00%> (ø)
src/testing/harness/support/selector.ts 100.00% <100.00%> (ø)
src/testing/renderer.ts 97.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a6a61...1759ced. Read the comment docs.

@agubler agubler merged commit a3d5620 into dojo:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants