Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inputs partially only controlled #887

merged 2 commits into from
Mar 16, 2021


Copy link

@agubler agubler commented Mar 16, 2021

Type: bug

The following has been addressed in the PR:


Changing how vdom work when setting values on an input element. This is to resolve an issue with Safari that jumps the caret to the end of the input when updating the value.

Resolves #886

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5c65779:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #887 (5c65779) into master (ad9f5e4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #887   +/-   ##
  Coverage   94.53%   94.54%           
  Files         127      127           
  Lines        8113     8114    +1     
  Branches     1894     1894           
+ Hits         7670     7671    +1     
  Misses        443      443           
Impacted Files Coverage Δ
src/core/vdom.ts 97.78% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad9f5e4...5c65779. Read the comment docs.

@agubler agubler merged commit 0ffee72 into dojo:master Mar 16, 2021
agubler added a commit to agubler/framework that referenced this pull request Mar 18, 2021
* failing unit test

* only set value if they are different
agubler added a commit that referenced this pull request Mar 18, 2021
* failing unit test

* only set value if they are different
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Text-input w. Controlled Value: Caret jumps to end
2 participants