Skip to content

Conversation

@agubler
Copy link
Member

@agubler agubler commented Mar 23, 2021

Type: bug

The following has been addressed in the PR:

Description:

The types for inferring the resource data and api types worked well with widgets that did not have properties (like all the tests) but did not work properly for widgets that had custom properties defined (most widgets)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #891 (bcbdf91) into master (2a36feb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #891   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files         127      127           
  Lines        8121     8121           
  Branches     1896     1896           
=======================================
  Hits         7678     7678           
  Misses        443      443           
Impacted Files Coverage Δ
src/core/middleware/resources.ts 95.89% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b508f...bcbdf91. Read the comment docs.

@agubler agubler merged commit 36aae1a into dojo:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants