Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take in to account virtual nodes when hydrating an existing DOM structure #896

Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Apr 16, 2021

Type: bug

The following has been addressed in the PR:

Description:

Virtual nodes should be treated the same as widgets when it comes to hydrating an existing DOM node structure. This means passing the merge node candidates down to when a virtual node is met.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b1ee4d9:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #896 (b1ee4d9) into master (36aae1a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files         127      127           
  Lines        8121     8123    +2     
  Branches     1896     1898    +2     
=======================================
+ Hits         7678     7680    +2     
  Misses        443      443           
Impacted Files Coverage Δ
src/core/vdom.ts 97.78% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36aae1a...b1ee4d9. Read the comment docs.

@agubler agubler merged commit 8620352 into dojo:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants