Support testing widgets with nested typed children#898
Merged
agubler merged 4 commits intodojo:masterfrom Apr 29, 2021
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7d8a7a1:
|
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
==========================================
+ Coverage 94.54% 94.59% +0.04%
==========================================
Files 127 127
Lines 8121 8135 +14
Branches 1896 1899 +3
==========================================
+ Hits 7678 7695 +17
+ Misses 443 440 -3
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Provides an API to support testing widgets with complex, nested typed children, for example:
Currently the test renderer's
childAPI enables consumers to instruct the renderer to resolve children to one level,renderer.child(WrappedWidget, 'child', 'params', 'for', 'renderer');this change adds an additional overload that enables users to provide params to resolve multiple children, including nested children. The function is typed to require all functional children to have params returned and the params are typed for the functional child. Using the example child interface above, this would look like:Note: The
paramsfunction was required for typings, otherwise the parameters for the functions were typed as tuples not arrays so need explicit casting i.e.['text'] as [string]- using an injected function seemed to be a more user friendly approach.Includes fixes required for parsing nested children in
assertRenderResolves #897