Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link: Always pass the target attribute regardless of whether the event is intercepted #907

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

matt-gadd
Copy link
Contributor

Type: bug

The following has been addressed in the PR:

Description:
We should always forward the target property to the anchor tag for Link.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit df2604a:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #907 (df2604a) into master (a7481f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #907   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files         127      127           
  Lines        8145     8150    +5     
  Branches     1901     1906    +5     
=======================================
+ Hits         7706     7711    +5     
  Misses        439      439           
Impacted Files Coverage Δ
src/routing/Link.ts 96.15% <100.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7481f7...df2604a. Read the comment docs.

@matt-gadd matt-gadd merged commit 7e90d43 into dojo:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants