Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

Fix maintainers check #58

Merged
merged 1 commit into from Oct 20, 2016
Merged

Conversation

matt-gadd
Copy link
Contributor

@matt-gadd matt-gadd commented Oct 18, 2016

Expected behaviour:
Can publish to npm with a maintainer in the maintainer list

Actual behaviour:
Failed the npm maintainer check.

For some reason I was only checking against the first maintainer in the array.

We dearly need some tests for the grunt tasks: #1

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@codecov-io
Copy link

Current coverage is 27.36% (diff: 100%)

Merging #58 into master will not change coverage

@@             master        #58   diff @@
==========================================
  Files            10         10          
  Lines           285        285          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits             78         78          
  Misses          207        207          
  Partials          0          0          

Powered by Codecov. Last update cd7858a...595d390

@agubler agubler merged commit e392ecd into dojo:master Oct 20, 2016
@dylans dylans added this to the 2016.10 milestone Oct 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants