New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how global define is unset #73

Merged
merged 1 commit into from Apr 25, 2016

Conversation

Projects
None yet
3 participants
@novemberborn
Member

novemberborn commented Apr 25, 2016

define was just a local variable. Actually unset the global define when requiring a Node module.

Looks like there was no test for this behavior. I'd add it but not quite sure where to start.


This fixes TypeError: ESP.parse is not a function output in test runs, see this Travis build for an example. In this case Intern uses loader to load a custom reporter, which then requires istanbul/lib/instrumenter. This module requires esprima which erroneously selects the AMD loader.

fix how global define is unset
`define` was just a local variable. Actually unset the global `define` when
requiring a Node module.

@kitsonk kitsonk self-assigned this Apr 25, 2016

@kitsonk kitsonk added this to the 2016.04 milestone Apr 25, 2016

@kitsonk kitsonk added the bug label Apr 25, 2016

@kitsonk kitsonk merged commit c4b4503 into master Apr 25, 2016

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jQuery Foundation CLA All authors have signed the CLA
Details

novemberborn added a commit to novemberborn/routing that referenced this pull request Apr 25, 2016

@novemberborn novemberborn deleted the fix-unset-global-define branch Apr 26, 2016

@novemberborn novemberborn referenced this pull request Apr 29, 2016

Closed

Distribution Formats #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment