This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Update get and identify APIs to return the item/id in one item case. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maier49
suggested changes
Dec 2, 2016
| @@ -83,12 +86,16 @@ function isPatch(patchObj: any): patchObj is {id: string; patch: Patch<any, any> | |||
| } | |||
|
|
|||
| const createStore: StoreFactory = compose<Store<{}, {}, any>, StoreOptions<{}, {}>>({ | |||
| get(this: Store<{}, {}, any>, ids: string[] | string): Promise<{}[]> { | |||
| get(this: Store<{}, {}, any>, ids: string[] | string): Promise<any> { | |||
There was a problem hiding this comment.
Could we type the return here to Promise<{} | {}[]>? That way it provides at least some guarantee about the return type in the implementation.
There was a problem hiding this comment.
Good point. I have made the change.
| @@ -222,8 +229,14 @@ const createStore: StoreFactory = compose<Store<{}, {}, any>, StoreOptions<{}, { | |||
| }); | |||
| }, | |||
|
|
|||
| identify(this: Store<{}, {}, any>, items: {}[] | {}) { | |||
| return instanceStateMap.get(this).storage.identify(Array.isArray(items) ? items : [ items ]); | |||
| identify(this: Store<{}, {}, any>, items: {}[] | {}): any { | |||
There was a problem hiding this comment.
Same question here really, could this return string | string[]?
There was a problem hiding this comment.
Although get can be done this way, identify can't as I tried. Please let me know if you have ways to get around this and I am happy to make it type safer.
|
Just a note, the CI has been hanging on I've seem this happen before. It seems it only fails occasionally. |
maier49
approved these changes
Dec 9, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Description:
Update get and identify APIs to return the item/id instead of the one item.id array in one item case.
Related Issue: #60