Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to 17146 #2

Merged
merged 1 commit into from Jun 10, 2013

Conversation

Projects
None yet
2 participants
@rcgill
Copy link
Member

commented Jun 6, 2013

Write string cache entries before module definition when interning strings as required by some IE loader paths. This fix only affects non-layer resources since layer resources appear to be expressed correctly.

write string cache entries before module definition when interning st…
…rings as required by some IE loader paths; fixes 17146
@wkeese

This comment has been minimized.

Copy link
Member

commented Jun 6, 2013

I didn't get a chance to test this today. I can try tomorrow if no one else has time to do it overnight (Japan time).

The key to testing (and to reproducing the original hang) is to remove all the template files from your build.

@ghost ghost assigned rcgill Jun 6, 2013

@wkeese

This comment has been minimized.

Copy link
Member

commented Jun 7, 2013

OK, on IE8 I reproduced the failure without the fix, and then confirmed it works with the fix, so this looks good to check in to the master/ and 1.9/ branches.

For the record, the commands I used were:

$ cd util/buildscripts
$ ./build.sh releaseDir=/ws/trunk/release action=release profile=standard
$ cd /ws/trunk/release
$ rm -rf release/dojo/dijit/templates release/dojo/dijit/*/templates
$ cp ie2.html release/dojo

ie2.html is https://bugs.dojotoolkit.org/attachment/ticket/17180/ie2.html

When loading ie2.html on IE8, correct result is that the alert shows up, failure is when the alert doesn't appear.

@rcgill rcgill merged commit 89bf278 into dojo:master Jun 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.