Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uglify use with newer node versions #78

Merged
merged 1 commit into from Sep 5, 2019
Merged

Fix uglify use with newer node versions #78

merged 1 commit into from Sep 5, 2019

Conversation

@jsonn
Copy link
Contributor

jsonn commented May 2, 2019

Recent versions of node enforce the callback argument to writeFile or fail with errors like:

error(356) The optimizer threw an exception; the module probably contains syntax errors. module identifier: dojo/dojo; exception: TypeError [ERR_INVALID_CALLBACK]: Callback must be a function TypeError [ERR_INVALID_CALLBACK]: Callback must be a function

Deal with this by explicitly providing a callback.

Recent versions of node enforce the callback argument to writeFile or fail with errors like:
```
error(356) The optimizer threw an exception; the module probably contains syntax errors. module identifier: dojo/dojo; exception: TypeError [ERR_INVALID_CALLBACK]: Callback must be a function TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
```
Deal with this by explicitly providing a callback.
@jsf-clabot

This comment has been minimized.

Copy link

jsf-clabot commented May 2, 2019

CLA assistant check
All committers have signed the CLA.

@dylans
dylans approved these changes May 31, 2019
Copy link
Member

dylans left a comment

Will land this as soon as possible.

@dylans
dylans approved these changes Sep 5, 2019
@dylans dylans merged commit 90f5ee8 into dojo:master Sep 5, 2019
1 check passed
1 check passed
licence/cla Contributor License Agreement is signed.
Details
dylans added a commit that referenced this pull request Sep 5, 2019
Recent versions of node enforce the callback argument to writeFile or fail with errors like:
```
error(356) The optimizer threw an exception; the module probably contains syntax errors. module identifier: dojo/dojo; exception: TypeError [ERR_INVALID_CALLBACK]: Callback must be a function TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
```
Deal with this by explicitly providing a callback.
(cherry picked from commit 90f5ee8)
dylans added a commit that referenced this pull request Sep 5, 2019
Recent versions of node enforce the callback argument to writeFile or fail with errors like:
```
error(356) The optimizer threw an exception; the module probably contains syntax errors. module identifier: dojo/dojo; exception: TypeError [ERR_INVALID_CALLBACK]: Callback must be a function TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
```
Deal with this by explicitly providing a callback.
(cherry picked from commit 90f5ee8)
dylans added a commit that referenced this pull request Sep 5, 2019
Recent versions of node enforce the callback argument to writeFile or fail with errors like:
```
error(356) The optimizer threw an exception; the module probably contains syntax errors. module identifier: dojo/dojo; exception: TypeError [ERR_INVALID_CALLBACK]: Callback must be a function TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
```
Deal with this by explicitly providing a callback.
(cherry picked from commit 90f5ee8)
dylans added a commit that referenced this pull request Sep 5, 2019
Recent versions of node enforce the callback argument to writeFile or fail with errors like:
```
error(356) The optimizer threw an exception; the module probably contains syntax errors. module identifier: dojo/dojo; exception: TypeError [ERR_INVALID_CALLBACK]: Callback must be a function TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
```
Deal with this by explicitly providing a callback.
(cherry picked from commit 90f5ee8)
dylans added a commit that referenced this pull request Sep 5, 2019
Recent versions of node enforce the callback argument to writeFile or fail with errors like:
```
error(356) The optimizer threw an exception; the module probably contains syntax errors. module identifier: dojo/dojo; exception: TypeError [ERR_INVALID_CALLBACK]: Callback must be a function TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
```
Deal with this by explicitly providing a callback.
(cherry picked from commit 90f5ee8)
dylans added a commit that referenced this pull request Sep 5, 2019
Recent versions of node enforce the callback argument to writeFile or fail with errors like:
```
error(356) The optimizer threw an exception; the module probably contains syntax errors. module identifier: dojo/dojo; exception: TypeError [ERR_INVALID_CALLBACK]: Callback must be a function TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
```
Deal with this by explicitly providing a callback.
(cherry picked from commit 90f5ee8)
@dylans

This comment has been minimized.

Copy link
Member

dylans commented Sep 5, 2019

Backported as:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.