Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "static" option for BTR #162

Merged
merged 4 commits into from Jun 11, 2019

Conversation

@agubler
Copy link
Member

commented Jun 11, 2019

Type: feature

The following has been addressed in the PR:

Description:

Adds a static option for BTR that completely removes the javascript and css from the generated index.html files.

When using routing only works with StateHistory (i.e. not hash routing).

Resolves #dojo/cli-build-app#280

agubler added 2 commits Jun 11, 2019
@codecov

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #162 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   85.09%   85.18%   +0.09%     
==========================================
  Files          41       41              
  Lines        1724     1728       +4     
  Branches      443      445       +2     
==========================================
+ Hits         1467     1472       +5     
+ Misses        257      256       -1
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 100% <100%> (ø) ⬆️
src/bootstrap-plugin/sync.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7349984...0eef6ad. Read the comment docs.

agubler added 2 commits Jun 11, 2019

@agubler agubler merged commit 7412f04 into dojo:master Jun 11, 2019

5 checks passed

codecov/patch 100% of diff hit (target 85.09%)
Details
codecov/project 85.18% (+0.09%) compared to 7349984
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.