Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix static BTR when no paths are specified #177

Merged
merged 1 commit into from Jul 5, 2019

Conversation

@agubler
Copy link
Member

commented Jul 5, 2019

Type: bug

The following has been addressed in the PR:

Description:

Ensure that the static option is honoured even when there are no paths defined in the .dojorc

Resolves #176

@agubler agubler requested a review from matt-gadd Jul 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 5, 2019

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files          41       41           
  Lines        1788     1788           
  Branches      469      469           
=======================================
  Hits         1529     1529           
  Misses        259      259
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25f6f8...2203a79. Read the comment docs.

@agubler agubler merged commit 5ea1a83 into dojo:master Jul 5, 2019

5 checks passed

codecov/patch 100% of diff hit (target 85.51%)
Details
codecov/project 85.51% (+0%) compared to c25f6f8
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.