Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

180 - Prefetching later-used chunks #193

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@rorticus
Copy link
Contributor

commented Aug 16, 2019

Type: bug
Type: feature

The following has been addressed in the PR:

Description:

Preloading additional chunks during BTR. All chunks that aren't needed on the current page are output as <link prefetch> tags to make future requests faster.

image

Resolves #180

@rorticus rorticus requested review from agubler and matt-gadd Aug 16, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 16, 2019

Codecov Report

Merging #193 into master will increase coverage by 0.02%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   85.93%   85.96%   +0.02%     
==========================================
  Files          40       40              
  Lines        1891     1902      +11     
  Branches      512      513       +1     
==========================================
+ Hits         1625     1635      +10     
- Misses        266      267       +1
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 97.66% <90.9%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17de84...af2cd7c. Read the comment docs.

@rorticus rorticus merged commit 9358445 into dojo:master Aug 22, 2019

5 checks passed

codecov/patch 90.9% of diff hit (target 85.93%)
Details
codecov/project 85.96% (+0.02%) compared to b17de84
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@rorticus rorticus deleted the rorticus:issue-180 branch Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.