Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On demand Build Time Rendering #246

Merged
merged 7 commits into from Apr 17, 2020
Merged

On demand Build Time Rendering #246

merged 7 commits into from Apr 17, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Feb 3, 2020

Type: feature

The following has been addressed in the PR:

Description:

Decouples build time rendering from webpack to be able to use "on demand" for a single path. Includes an express middleware that can be used to generate the static html for a visited path if it has not been generated since the last re-build. Once the html has been generated it will not re-run until the build has invalidated.

Related to dojo/cli-build-app#367

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #246 into master will increase coverage by 0.42%.
The diff coverage is 98.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   84.80%   85.23%   +0.42%     
==========================================
  Files          48       49       +1     
  Lines        2211     2282      +71     
  Branches      586      600      +14     
==========================================
+ Hits         1875     1945      +70     
- Misses        336      337       +1     
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 94.91% <98.50%> (+0.32%) ⬆️
src/build-time-render/BuildTimeRenderMiddleware.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1d56b...2dd7ed6. Read the comment docs.

@agubler agubler merged commit 6b06a1d into dojo:master Apr 17, 2020
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants