On demand Build Time Rendering#246
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 84.80% 85.23% +0.42%
==========================================
Files 48 49 +1
Lines 2211 2282 +71
Branches 586 600 +14
==========================================
+ Hits 1875 1945 +70
- Misses 336 337 +1
Continue to review full report at Codecov.
|
agubler
force-pushed
the
on-demand-btr
branch
from
a0d4793 to
538b47d
Compare
matt-gadd
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Decouples build time rendering from webpack to be able to use "on demand" for a single path. Includes an express middleware that can be used to generate the static html for a visited path if it has not been generated since the last re-build. Once the html has been generated it will not re-run until the build has invalidated.
Related to dojo/cli-build-app#367