Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set document title for build time rendered pages #260

Merged
merged 1 commit into from Apr 9, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Apr 9, 2020

Type: feature

The following has been addressed in the PR:

Description:

Sets the document title for pages built with BTR based on the title of the rendered output.

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #260 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   84.78%   84.80%   +0.02%     
==========================================
  Files          48       48              
  Lines        2208     2211       +3     
  Branches      585      586       +1     
==========================================
+ Hits         1872     1875       +3     
  Misses        336      336              
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 94.58% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c1f38...2a7c0f8. Read the comment docs.

@agubler agubler merged commit 8a1d56b into dojo:master Apr 9, 2020
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants