Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor comments
tests/functional/Drag.ts
Outdated
import * as registerSuite from 'intern!object'; | ||
import * as assert from 'intern/chai!assert'; | ||
const { registerSuite } = intern.getInterface('object'); | ||
const { assert } = intern.getPlugin('chai'); | ||
// import pollUntil = require('intern/dojo/node!leadfoot/helpers/pollUntil'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this commented import?
} | ||
rAFStub.reset(); | ||
} | ||
|
||
function resolveRIC() { | ||
for (let i = 0; i < rICStub.callCount; i++) { | ||
rICStub.getCall(0).args[0](); | ||
rICStub.getCall(i).args[0](); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
const factoryRegistry = new Registry(); | ||
factoryRegistry.define('my-widget', promise); | ||
factoryRegistry.get('my-widget'); | ||
resolveFunction(WidgetBase); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn’t the point of this test to resolve after the get?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. I'll fix this and the next test.
Type: enhancement
The following has been addressed in the PR:
Description:
Rather than try to figure out the merge conflicts from master and Ed's PR, I did a clean conversion and cherry picked things from Ed's branch. One note: I did not indent the
tests: {}
blocks to make it easier to review. After approval and before merging, I will indent thetests: {}
blocks.Resolves #617