This repository has been archived by the owner. It is now read-only.

Add custom element decorator #792

Merged
merged 7 commits into from Dec 1, 2017

Conversation

Projects
None yet
4 participants
@maier49
Contributor

maier49 commented Nov 30, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:
Adds a decorator that creates a custom element
Resolves #788

@maier49 maier49 requested a review from kitsonk Nov 30, 2017

@kitsonk kitsonk requested review from matt-gadd and agubler Nov 30, 2017

@kitsonk

This comment has been minimized.

Member

kitsonk commented Nov 30, 2017

Additions to the README?

@dylans dylans added this to the beta.5 milestone Dec 1, 2017

@maier49 maier49 force-pushed the maier49:customElementDecorator branch from a1e02de to 285d34a Dec 1, 2017

@kitsonk

kitsonk approved these changes Dec 1, 2017

This makes sense to me but it was @matt-gadd who had the idea in his head and should validate this.

README.md Outdated
@@ -1183,7 +1183,11 @@ class MyWidgetWithTsx extends Themed(WidgetBase)<MyProperties> {
Widgets can be turned into [Custom Elements](https://www.w3.org/TR/2016/WD-custom-elements-20161013/) with
minimal extra effort.
Just create a `CustomElementDescriptor` factory and use the `@dojo/cli` build tooling to do the rest of the work,
There are two ways to turn a widget into a custom element.

This comment has been minimized.

@matt-gadd

matt-gadd Dec 1, 2017

Contributor

can we get rid of the description of using the CustomElementDescriptor completely? we plan to deprecate it as user facing feature in the future.

This comment has been minimized.

@maier49

maier49 Dec 1, 2017

Contributor

The README is updated now to only mention the decorator.

@maier49 maier49 merged commit 4a0447b into dojo:master Dec 1, 2017

4 checks passed

codecov/patch 100% of diff hit (target 98.39%)
Details
codecov/project 98.4% (+<.01%) compared to 4ba2737
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@maier49 maier49 deleted the maier49:customElementDecorator branch Dec 1, 2017

@agubler agubler referenced this pull request Jan 18, 2018

Merged

Dojo 2 beta 5 blog post #370

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.