Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget themability check #401

Closed
tomdye opened this issue Dec 6, 2017 · 3 comments
Closed

Widget themability check #401

tomdye opened this issue Dec 6, 2017 · 3 comments

Comments

@tomdye
Copy link
Member

tomdye commented Dec 6, 2017

Enhancement

We should take time to check how themeable the widgets we have created really are.
A popular style of web components that people often like to use is material. A good way to test the themeabilty of our components would be to have a go at creating a material theme.

@kitsonk kitsonk added the rc label Dec 8, 2017
@kitsonk kitsonk added this to the rc.1 milestone Dec 8, 2017
@agubler agubler removed this from the rc.1 milestone Jan 4, 2018
@agubler agubler added the rc label Jan 4, 2018
@agubler agubler added this to the rc.1 milestone Jan 4, 2018
@dylans
Copy link
Member

dylans commented Jan 5, 2018

Rather than doing material at this time, why don't we go through this process and create a Dojo 1 flat theme for Dojo 2's widgets ( see comments at dojo/examples#275 )... this will improve interop with Dojo 1 and also verify that this is working as it should.

@tomdye
Copy link
Member Author

tomdye commented Jan 5, 2018

I think the reason for Material was that it is a little more complicated that the dojo 1 flat theme and thus a better test of the theming system. I understand your point though.

@dylans dylans modified the milestones: rc.1, rc.2 Mar 1, 2018
@agubler agubler removed the rc label Mar 9, 2018
@dylans dylans removed this from the rc.2 milestone Mar 20, 2018
@tomdye
Copy link
Member Author

tomdye commented Nov 22, 2018

This is covered in the material epic #615

@tomdye tomdye closed this as completed Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants