Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move crontab to recommended location #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@jonathan-s
Copy link

@jonathan-s jonathan-s commented May 9, 2019

Fixes the following issue #6. This PR will move a file crontab to the recommended location for crontab. The user of the plugin will need to add two extra permissions in sudoers to let the dokku user overwrite the crontab correctly the next time their application is deployed.

README.md Outdated
Add the following line. It will allow the dokku user to overwrite the old crontab as well as restart the cron service after it has been overwritten.

```bash
dokku ALL=(ALL) NOPASSWD: /bin/cp, /usr/sbin/service cron restart
Copy link
Member

@josegonzalez josegonzalez May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be added to it's own sudoers file during the install phase of the plugin.

@jonathan-s jonathan-s force-pushed the master branch 3 times, most recently from 86ce198 to 02fc60d May 10, 2019


echo "%dokku ALL=(ALL) NOPASSWD: /bin/cp, /usr/sbin/service cron restart" > /etc/sudoers.d/dokku-supply-config
chmod 0440 "/etc/sudoers.d/dokku-supply-config"
Copy link
Author

@jonathan-s jonathan-s May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josegonzalez I've had a look at the nginx and postgres plugin and it seems like this is what's needed. However, when I try to install the plugin the dokku-supply-config is not created. I'm not sure exactly what I'm missing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants