Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not allow http2 for nginx 1.10.x #2435
Description of problem:
dokku turns on http2 for nginx 1.10.x and above. But this version of nginx has a broken http2 implementation, and http2 aware clients fail to connect to it. Here is an example case: curl/curl#1040
nginx 1.11.x seems to be fine.
Output of the following commands
Environment details (AWS, VirtualBox, physical, etc.):
How was Dokku installed?:
As in the dokku manual.
Steps to Reproduce:
An HTTP response.
I know, sorry, it was mostly a note for myself.
I think what happened was that I upgraded nginx, and everything was fine then, but then restarted some apps, and nginx started failing. Then I downgraded nginx, removed http2 support, and now everything is fine.
It could be unrelated, actually, so maybe 1.11.x is OK with dokku 0.7.x, I am not sure yet. I will need to pull up a test system to experiment, that's why it is taking time.
Hi guys, just to let you know that nginx-1.11.5 fixed it for me.
There's also something that may be of interest here:
This may be a clue that there's some http client configuration to do here to correctly connect to nginx.
EDIT: just to be clear, the http golang client was working without any problem on previous nginx version with spdy and it works just as fine with nginx-1.11.5 without any modification.