Adds support for ArchLinux as host OS #1918
Conversation
I pushed an updated version to the AUR https://aur.archlinux.org/packages/dokku/ - this works now with the basic dokku setup. |
|
Good work!
|
I easily could add you as co-maintainer. It's only the Arch User Repo where users could put in their proposals for PKGBUILDs (the way to describe packages).
The whole packaging follows the arch package building. On Arch Linux run: But you don't need to do this and then place the package somewhere but you simply push to that AUR repo your changes to the PKGBUILD file and then other users could use pacaur or yaourt (helper scripts to pull these PKGBUILD files from AUR, build them and install them together with all dependencies).
What does this mean? |
BTW: It was there before - but was outdated. Today I requested co-maintainer-ship and got it. So this should not be a deal-breaker. Also you could click the "flag this package as out of date" and the maintainer will get a notification. |
|
We have release docs for dokku that need to be updated. I wasn't aware that it was there before, though I would have requested the same before. I'll see about asking for maintainership later. |
| @@ -33,7 +35,7 @@ After=docker.target | |||
| [Service] | |||
| Type=simple | |||
| User=dokku | |||
| ExecStart=/usr/local/bin/dokku ps:restore | |||
| ExecStart=$dokku_path ps:restore | |||
There was a problem hiding this comment.
@michaelshobbs @josegonzalez I added the changes to this file to fix the restore process on ArchLinux. It works there just fine and should also work without issues on all other platforms.
There was a problem hiding this comment.
Where is the file located on arch linux?
There was a problem hiding this comment.
binaries on arch usually reside in /usr/bin/ - they had some huge restructurings some time ago, when they moved a lot to one location.
|
|
I rebased this ontop of 0.4.14 |
|
Whats left to get this into master? |
Nothing from my point of view for 0.4.14 (the todo item is for 0.5.0 and the PKGBUILD file). You just want to check for further usages of apt-get. I use this version to let it run on my arch linux server and it works. I will try to fix the plugins once I use them (I already fixed the lets encrypt plugin for ArchLinux) |
|
@josegonzalez I'm also around in IRC/Slack - so just ping me if you have questions or want to know more about the packaging in ArchLinux |
|
I've added you as a maintainer of dokku so we can continue to have A+ arch support :) Here are the release docs. Please update them so I can also handle arch releases. My nick on archlinux is |
|
|
I prepared the package for 0.5.0 and added sigil as separate package. And I also updated the documentation. |
| That is the usual workflow: | ||
|
|
||
| ```shell | ||
| updpkgsums # update sha sums - compare them with the original ones |
There was a problem hiding this comment.
Are these commands only available on arch?
There was a problem hiding this comment.
Yes - and the derivates, because they come with the package manager.
There was a problem hiding this comment.
Can you update the Vagrantfile so I can have a vm for running these arch commands?
There was a problem hiding this comment.
$ pacman -Qo /usr/bin/updpkgsums
/usr/bin/updpkgsums ist in pacman 5.0.0-1 enthalten
$ pacman -Qo /usr/bin/makepkg
/usr/bin/makepkg ist in pacman 5.0.0-1 enthalten
$ pacman -Qo /usr/bin/mksrcinfo
/usr/bin/mksrcinfo ist in pkgbuild-introspection 8-1 enthaltenThere was a problem hiding this comment.
Can you update the Vagrantfile so I can have a vm for running these arch commands?
Where should the Vagrant file go? Because the build information is in a different repo (see below - the AUR repo).
There was a problem hiding this comment.
Can you hop on slack so we can discuss this?
|
From my side everything is done for now. This adds the basic support for ArchLinux. All the other stuff should maybe be done in other PRs (like the integration of the installer in ArchLinux, because it includes major changes - for not duplicate everything). |
| # update pacman lists, install pkgbuild-introspection and add GPG to verify cower package | ||
| vm.vm.provision :shell, :inline => "pacman -Sy && pacman -S --needed --noconfirm pkgbuild-introspection" | ||
|
|
||
| $script = <<SCRIPT |
There was a problem hiding this comment.
Can you move this to a makefile target and then update the release notes?
There was a problem hiding this comment.
Will do tomorrow.
|
@josegonzalez I moved the inline commands to an |
| arch-all: arch-dokku | ||
| echo "Done" | ||
|
|
||
| arch-setup: |
There was a problem hiding this comment.
Damn ... I removed this to speed up the test runs :(
* fix rsyslog handling * don't hardcode dokku path * add documentation for ArchLinux package build * add vagrant machine to run the ArchLinux specific steps * add step in release process for ArchLinux * enhance docs for easy ArchLinux steps
|
@josegonzalez Is there something left for this PR? I'm happy to fix it for you then :) |
Adds support for ArchLinux as host OS
|
|
@josegonzalez I tried to get dokku running on ArchLinux instead of fiddling more around with the "let it run in docker" approach (see #1076). I hope this is okay too.
This also comes with an updated PKGBUILD for the Arch User Repo:
https://github.com/MorrisJobke/aur-dokku/compare/update-to-0.4.13https://aur.archlinux.org/cgit/aur.git/commit/PKGBUILD?h=dokku&id=87eec064d569e3a1b6f42dfcbca5502d38e51601The only thing left for the Arch package to work is the herokuish app. I will look into this later.