Allow triggering a release via the contrib/release script
#2684
Conversation
|
Long term, we can use this to generate a deb package for all pull requests and potentially install dokku within a docker container, to validate that the deb packages can in fact still be built and contain the functionality we want. The betafish repository will serve to hold these HIGHLY unsupported packages. |
josegonzalez
force-pushed
the
automated-release
branch
from
4758cd7
to
c2cac92
Compare
- Requires docker, git, and package_cloud gems - Requires the PACKAGECLOUD_API_TOKEN environment variable - Builds both a deb and rpm, pushing both to packagecloud - Upgrades the golang build environment to 1.7.5 - Combines both build Dockerfiles into a single, generic env - Fixes issue where internal-functions file for tar plugin was not executable - Ensures that built plugins have a callback to clean up their source files before packaging - Adds support for “betafish” releases, which are untested versions of Dokku that are available via a separate packagecloud repository.
josegonzalez
force-pushed
the
automated-release
branch
from
c2cac92
to
217e491
Compare
| @@ -1091,7 +1091,7 @@ Thanks to the *many* contributors for making this release our best release so fa | |||
| - #1473: @josegonzalez Handle crashing containers by using restart=on-failure policy | |||
| - #1476: @michaelshobbs Support static nginx port when deploying without an application VHOST | |||
| - #1476: nginx proxy without VHOST | |||
| - #1477: @arthurschreiber Support removing config variables that contain `\n`. | |||
| - #1477: @arthurschreiber Support removing config variables containing newlines. | |||
There was a problem hiding this comment.
Curious why this change was necessary.
There was a problem hiding this comment.
The thing that writes out history was rewriting these as actual newlines.
contrib/build.Dockerfile
Outdated
| WORKDIR ${WORKDIR} | ||
|
|
||
| COPY Makefile ${WORKDIR}/ | ||
|
|
There was a problem hiding this comment.
nitpick: group same directives. i.e. no extra whitespace
| sed -i "s/^Version: .*/Version: `cat /tmp/build/var/lib/dokku/STABLE_VERSION`/g" /tmp/build/DEBIAN/control | ||
| dpkg-deb --build /tmp/build "/tmp/dokku_`cat /tmp/build/var/lib/dokku/STABLE_VERSION`_$(DOKKU_ARCHITECTURE).deb" | ||
| lintian "/tmp/dokku_`cat /tmp/build/var/lib/dokku/STABLE_VERSION`_$(DOKKU_ARCHITECTURE).deb" | ||
| sed -i.bak "s/^Version: .*/Version: `cat /tmp/build/var/lib/dokku/STABLE_VERSION`/g" /tmp/build/DEBIAN/control && rm /tmp/build/DEBIAN/control.bak |
There was a problem hiding this comment.
Not sure if you actually wanted to save the .bak for troubleshooting but if not, you can use -i ""
There was a problem hiding this comment.
Was testing this on OS X, which doesn't have the raw -i flag.
There was a problem hiding this comment.
Right. I'm pretty sure you can use -i "" (note: the double quotes) to avoid the backup file being written.
There was a problem hiding this comment.
shrug this is the pattern we've followed elsewhere.
There was a problem hiding this comment.
That's not necessarily a reason to leave it as is though. In any case, if you're comfortable with maintaining the pattern, then that's cool with me.
There was a problem hiding this comment.
Yep I'm happy with it.
josegonzalez
changed the title
contrib/release scriptcontrib/release script
To run it: