Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an 'add-ons' plugin, which provides heroku style addons. #292

Closed
wants to merge 20 commits into from

Conversation

Projects
None yet
@plietar
Copy link
Contributor

plietar commented Nov 5, 2013

This is still WIP. I've created the PR so people can comment it.
Add-ons provide access to services (e.g. database) by applications.

It is quite similar to heroku's addons.
Add-ons provide a URL, which is passed to applications through environment variables.
The contents of the url is up to the add-on, but should be described in the add-on's doc.

The description of how to use/create plugins is in the docs folder.

See https://github.com/plietar/dokku-addons for addons.

I have added some tests, but they are part of the dokku-addons repo, and work only in vagrant for now.

TODO

  • Basic commands (add/remove/url)
  • Help message
  • Unprovision automatically all add-ons in pre-delete
  • Manage add-ons enabling/installation (eg creation of service's container)
  • Write add-ons for major services
  • Add some automated testing.
  • Make testing work on travis.
  • Add backup-export/backup-import support. (Needs a small change in the backup PR, I'll make a PR or commit them soon)
  • Start addons container after reboot (Possible integration with dokku ps #298, or plain upstart)

Comments/suggestions are welcome.

@progrium

This comment has been minimized.

Copy link
Contributor

progrium commented Nov 5, 2013

Wow. This'll take some time to digest/review but it looks amazing.

@plietar

This comment has been minimized.

Copy link
Contributor Author

plietar commented Nov 5, 2013

Sure, this is still far from being complete, and would be for a not so soon release.

@progrium progrium referenced this pull request Nov 5, 2013

Closed

Sidekiq plugin feedback #293

@progrium

This comment has been minimized.

Copy link
Contributor

progrium commented Nov 5, 2013

This'll be a great headlining feature for 0.3.0

@plietar plietar referenced this pull request Nov 9, 2013

Closed

dokku ps #298

7 of 10 tasks complete
@plietar

This comment has been minimized.

Copy link
Contributor Author

plietar commented Nov 27, 2013

It should be quite stable now, there a few non-essential things left todo.

I've written addons for mariadb, postgresql and redis.
They are on a seperate repo
https://github.com/plietar/dokku-addons

Cloning it and running make install should be enough.

Alternatively, cloning it on the host and running make vagrant will install it into the vagrant box.
The ssh keys need to be setup. (Easiest way is to run dokku's test/run_vagrant)

plietar added some commits Nov 4, 2013

Add an 'add-ons' plugin, which provides heroku style add-ons.
Add-ons provide access to services (e.g. database) by applications.
This is still WIP.
Add enable/disable to the add-on plugin.
Add-ons must be enabled before they are used. This allows add-ons to
install dependencies, allocate necessary resources, ...
Fail when disabling an add-on which is still in use.
This is safer and simpler than unprovisioning all apps.
Make test_deploy more flexible.
Allow deploying an application in any path, and allow applications to
have a setup script
@enricostano

This comment has been minimized.

Copy link

enricostano commented Jan 19, 2014

Any news on this?

@Peeja

This comment has been minimized.

Copy link

Peeja commented Jan 21, 2014

I'm not using Dokku at the moment, but a few weeks ago I was playing with it using this PR, and things worked well. I'd love to see it land on master.

@sardaukar

This comment has been minimized.

Copy link

sardaukar commented Jan 30, 2014

+1

@AlJohri

This comment has been minimized.

Copy link
Contributor

AlJohri commented Mar 6, 2014

+1 this looks amazing

@zachlatta

This comment has been minimized.

Copy link

zachlatta commented Mar 15, 2014

👍

@Kloadut

This comment has been minimized.

Copy link
Contributor

Kloadut commented Mar 31, 2014

Looks Awesome To Me

@Zenedith

This comment has been minimized.

Copy link

Zenedith commented Mar 31, 2014

👍

@jnettome

This comment has been minimized.

Copy link

jnettome commented Sep 11, 2014

Anything new here?

@progrium

This comment has been minimized.

Copy link
Contributor

progrium commented Sep 11, 2014

Not yet. Soon...

On Thu, Sep 11, 2014 at 2:46 PM, João Netto notifications@github.com
wrote:

Anything new here?


Reply to this email directly or view it on GitHub
#292 (comment).

Jeff Lindsay
http://progrium.com

@josegonzalez

This comment has been minimized.

Copy link
Member

josegonzalez commented Nov 15, 2014

Small update: This will likely land on 0.4.0.

@AlJohri

This comment has been minimized.

Copy link
Contributor

AlJohri commented Nov 15, 2014

that's so exciting! 👍

@sardaukar

This comment has been minimized.

Copy link

sardaukar commented Nov 15, 2014

👍

@josegonzalez

This comment has been minimized.

Copy link
Member

josegonzalez commented Nov 15, 2014

Please do not comment unless you are commenting on it being broken or not supporting some case. Helps keep my inbox quiet :)

@josegonzalez

This comment has been minimized.

Copy link
Member

josegonzalez commented Aug 25, 2015

Supersceded by #1408. Thanks for the work @plietar. I'm going to come back to this pr and scavenge for the good parts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.