New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $DOCKER_VERSION to specify docker version #407

Merged
1 commit merged into from Jan 8, 2014

Conversation

Projects
None yet
2 participants
@banyan
Copy link
Contributor

banyan commented Jan 6, 2014

Since docker is very active development, and it has regression too.
This change can be handy to build dokku. What do you think?

# DOCKER_VERSION=0.7.2 make install
@plietar

This comment has been minimized.

Copy link
Contributor

plietar commented Jan 6, 2014

LGTM
We could also pin it, at least on stable releases.

@ghost

This comment has been minimized.

Copy link

ghost commented Jan 6, 2014

(re:pinning) I think the issue with this is that the older docker releases are short lived - the docker team used to remove all old versions after a very short period, breaking installation for everyone and requiring a version bump every so often. Unsure if they do this now though - if they do we may have to look at hosting copies elsewhere

@ghost

This comment has been minimized.

Copy link

ghost commented Jan 8, 2014

Looking at their repo it seems that they keep older versions around so pinning would work fine as is

ghost pushed a commit that referenced this pull request Jan 8, 2014

rhy-jot
Merge pull request #407 from banyan/specify-docker-version
Add $DOCKER_VERSION to specify docker version

@ghost ghost merged commit 8fca220 into dokku:master Jan 8, 2014

1 check passed

default The Travis CI build passed
Details
@ghost

This comment has been minimized.

Copy link

ghost commented Jan 8, 2014

Thanks!

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment