Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

2 tests failed - double un/subscription #17

Closed
SkinTeam opened this Issue · 3 comments

2 participants

@SkinTeam

Having completed all the setup steps, running python manage.py test yields these two errors:

FAIL: test_subscribe_twice (newsletter.tests.test_web.WebUserSubscribeTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/newsletter/tests/test_web.py", line 261, in test_subscribe_twice
    self.assertNotContains(r, 'action="%s"' % self.subscribe_confirm_url)
  File "/usr/lib/python2.7/dist-packages/django/test/testcases.py", line 447, in assertNotContains
    msg_prefix + "Response should not contain '%s'" % text)
AssertionError: Response should not contain 'action="/newsletter/test-newsletter/subscribe/confirm/"'

======================================================================
FAIL: test_unsubscribe_twice (newsletter.tests.test_web.WebUserSubscribeTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/newsletter/tests/test_web.py", line 321, in test_unsubscribe_twice
    self.assertNotContains(r, 'action="%s"' % self.unsubscribe_confirm_url)
  File "/usr/lib/python2.7/dist-packages/django/test/testcases.py", line 447, in assertNotContains
    msg_prefix + "Response should not contain '%s'" % text)
AssertionError: Response should not contain 'action="/newsletter/test-newsletter/unsubscribe/confirm/"'
@dokterbob
Owner

Related: #5

@dokterbob
Owner

@SkinTeam I am planning a 0.5 release of django-newsletter, and I need your feedback! Since GH has removed private messaging and you don't have an email address set on your profile, I thought I might as well abuse GH's issues to give you a little heads-up:

Dear contributors to django-newsletter,

Your efforts, pull requests, bugreports and feature-suggestions have not gone unnoticed. Thanks so much for your contributions!

In the next two weeks I am planning to take about a day to:

Fix some long-standing issues
Implement some much-needed features
Merge in some of your contributions!
In order to have a good view on what to implement first, I would very much like some feedback from you guys. Both on currently opened issues (+1/-1) or in the form of new issues (bugs, feature requests etc).

Please take a look at all the currently open issues at:
https://github.com/dokterbob/django-newsletter/issues?state=open

The idea is to have django-newsletter 0.5 finished, tested and documented by the 16th of september. If you want some clue as to what day exactly I will take for this, look to see when there's rainy weather in Amsterdam. ;) It'll highly likely be the 15th or 16th.

Until that time: please feel free to nag, bug me, discuss and work with me on this upcoming release.

Kind regards,
Mathijs

'The long-lost maintainer of django-newsletter.' ;)

@dokterbob
Owner

@SkinTeam I have not been able to reproduce this test failure in the current release so I'm closing this one now. If you can tell me more on how to replicate the issue I'll look further into it.

@dokterbob dokterbob closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.