Newsletter uses site manager as 'objects' #4

femans opened this Issue Mar 25, 2011 · 1 comment


None yet
2 participants

femans commented Mar 25, 2011

The Newsletter-object uses the SiteManager by default as objects. This is bad, because not selecting the current site in the admin makes a Newsletter disappear.

Suggested solution: define a second in_site manager as SiteManager and use it everywhere the user interfaces with the software. This way, the admin will still use the objects manager.

Note: make sure you define the objects manager explicitly after having defined a second manager.


dokterbob commented Nov 19, 2012

Preliminary recognition of what needs to be done:

  1. Some basic tests for the sites mechanism. (ie. check URL in e-mail, check per-site submission and archive visibility)
  2. Use on_site for all user-facing parts and the submission mechanism.

Alternately, just removing support for the sites mechanism would hurt probably hurt very few users and wll make the codebase a lot lighter. @SkinTeam So once again: are you actually using it? ;)

dokterbob closed this in dad8229 Nov 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment