Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threading headers to page change notification mails #120

Closed
wants to merge 3 commits into from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jul 19, 2012

configurable with $conf['mailthreads'] (default on)

old patch import:
http://git.pld-linux.org/?p=packages/dokuwiki.git;a=history;f=dokuwiki-mailthreads.patch

@michitux
Copy link
Collaborator

I think this could be good for mail clients which don't automatically thread mails (like gmail). I could only see one issue: this will break when you edit the page yourself in between two edits by other users. Maybe it would also be good to make the message id a bit more unique, but I'm not sure if this is actually needed (and I also don't know if this format is correct).

@glensc
Copy link
Contributor Author

glensc commented Jul 19, 2012

i don't see how it could go wrong, if for each edit mail is sent out the and message id is page $rev, it will just magically match. there is no user information in the id, just pagename?rev=$rev@wiki.url

@michitux
Copy link
Collaborator

The problem is that you don't get emails for your own edits when you are subscribed to a page, which means there is one message id missing and the mail client can't find the thread anymore.

@glensc
Copy link
Contributor Author

glensc commented Jul 20, 2012

ah, okay. i'm using $conf['notify'] to receive all mails, therefore i haven't noticed this behaviour.

i can't think of solution for this case how to avoid it. and it's not exactly breakage, just you'll get different mail threads in your mail client.

@splitbrain
Copy link
Collaborator

I like this. I don't think we need a config option for this though. It wouldn't hurt anyone, right?

@glensc
Copy link
Contributor Author

glensc commented Jul 30, 2012

i added it just to be safe, because i don't know (can't even imagine) what could go wrong.

should i remove the config part from the PR?

@splitbrain
Copy link
Collaborator

Yes, let's get rid of that.

@glensc
Copy link
Contributor Author

glensc commented Jul 30, 2012

uh, there's media notify too, i'll commit change for that as well

@splitbrain
Copy link
Collaborator

This should be merged with the changes of #125

@michitux
Copy link
Collaborator

Implemented/merged in 10eac67.

@michitux michitux closed this Jan 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants