Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapping _unregister in BaseWSEndpoint in cancel scope causes RuntimeError, if unregister tries to cancel scope in outer TaskGroup #54

Closed
dolamroth opened this issue May 17, 2023 · 0 comments
Closed

Wrapping _unregister in BaseWSEndpoint in cancel scope causes RuntimeError, if unregister tries to cancel scope in outer TaskGroup #54

dolamroth opened this issue May 17, 2023 · 0 comments
Labels
bug Something isn't working
Milestone
0.2

Comments

@dolamroth
Copy link
Owner

starlette-web/starlette_web/common/ws/base_endpoint.py

Line 101 in ded69ce

with anyio.fail_after(delay=self.EXIT_MAX_DELAY, shield=True):

@dolamroth dolamroth added the bug Something isn't working label May 17, 2023
@dolamroth dolamroth added this to the 0.2 milestone May 17, 2023
@dolamroth dolamroth changed the title Do not wrap _unregister in BaseWSEndpoint in cancel scope Wrapping _unregister in BaseWSEndpoint in cancel scope causes RuntimeError, if unregister tries to cancel scope in outer TaskGroup May 17, 2023
dolamroth added a commit that referenced this issue May 18, 2023
@dolamroth
Refs #54: Remade shielding of _unregister_background_task in BaseWSEn…
79b9dcb 
…dpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
1 participant
@dolamroth