Study@3 #21
Study@3 #21
Conversation
jonathanong
force-pushed
the
study-rewrite
branch
2 times, most recently
from
0a750dc
to
4ee42b8
Compare
jonathanong
force-pushed
the
study-rewrite
branch
from
d97e1ac
to
65eb331
Compare
src/study.js
Outdated
| const { root } = this; | ||
| if (!root) return; | ||
|
|
||
|
|
src/study.js
Outdated
| if (!root) return; | ||
|
|
||
|
|
||
| const currentClassNames = root.className.split(/\s+/g) |
There was a problem hiding this comment.
Could we use classList here instead?
There was a problem hiding this comment.
it doesn't support returning all classes :/
| if (!Array.isArray(data)) { normalizedData = [data]; } | ||
| define(tests) { | ||
| let normalizedData = tests; | ||
| if (!Array.isArray(tests)) normalizedData = [tests]; | ||
|
|
||
| normalizedData.forEach((test) => { |
| previousAssignments, | ||
| userAssignments, | ||
| persistedUserAssignments, | ||
| } = this; | ||
|
|
||
| this.providedTests.forEach((test) => { |
There was a problem hiding this comment.
airbnb eslint -_- we need to just make eslint-config-dsc
src/study.js
Outdated
| delete this.persistedUserAssignments[testName]; | ||
| this.removeClasses(testName); | ||
| } else { | ||
| this.userAssignments[testName] = |
There was a problem hiding this comment.
eh? where's the right hand side of this assignment?
There was a problem hiding this comment.
right below it ;)
There was a problem hiding this comment.
i would refactor this to be more readable. took a lot of my mental energy to grok what was going on here.
There was a problem hiding this comment.
hahaha i can make it one line instead
src/study.js
Outdated
| delete this.persistedUserAssignments[testName]; | ||
| this.removeClasses(testName); | ||
| } else { | ||
| this.userAssignments[testName] = |
There was a problem hiding this comment.
i would refactor this to be more readable. took a lot of my mental energy to grok what was going on here.
src/stores/memory.js
Outdated
| @@ -0,0 +1,14 @@ | |||
|
|
|||
|
|
|||
closes #20
primary changes:
defaultandwinnersupport